Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fix ZSTD_LIB_MINIFY build option #3366

Merged
merged 1 commit into from
Dec 16, 2022
Merged

[build] Fix ZSTD_LIB_MINIFY build option #3366

merged 1 commit into from
Dec 16, 2022

Conversation

terrelln
Copy link
Contributor

ZSTD_LIB_MINIFY broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K with ZSTD_LIB_MINIFY set.

Fixes #3066.

@terrelln terrelln mentioned this pull request Dec 16, 2022
Closed
@Cyan4973
Copy link
Contributor

Cyan4973 commented Dec 16, 2022 •
edited
Loading

More an opened question :
would there be any way to detect such a regression ?
would it be a good idea to add a test for that ?

@terrelln
Copy link
Contributor Author

Add a test

@terrelln
[build] Fix ZSTD_LIB_MINIFY build option
c9691d9 
`ZSTD_LIB_MINIFY` broke in 8bf699a.

This commit fixes the macro and the static library shrinks from ~600K to 324K
with ZSTD_LIB_MINIFY set.

Fixes facebook#3066.
Cyan4973
Cyan4973 reviewed Dec 16, 2022
View reviewed changes
.github/workflows/dev-short-tests.yml
@@ -236,6 +236,20 @@ jobs:
# msbuild "build\VS2010\zstd.sln" /m /verbosity:minimal /property:PlatformToolset=v140
# /t:Clean,Build /p:Platform=${{matrix.platform}} /p:Configuration=${{matrix.configuration}}

# This tests that we don't accidently grow the size too much.
# If the size grows intentionally, you can raise these numbers.
# But we do need to think about binary size, since it is a concern.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@terrelln terrelln merged commit 0c42424 into facebook:dev Dec 16, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library bloat (with ZSTD_LIB_MINIFY=1) since v1.5.1
3 participants
@terrelln @Cyan4973 @facebook-github-bot